Deprecate instruction_durations, timing_constraints and backend_properties
#13338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11593834442Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ElePT
reviewed
Oct 21, 2024
qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Elena Peña Tapia <[email protected]>
|
Would you like me to take care of the reno? I can do that. |
ElePT
reviewed
Oct 28, 2024
ElePT
added
Changelog: Deprecation
ElePT
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13306
Details and comments
The function
generate_preset_pass_managerandtranspilehave very complicated precedence rules on how the parameters are handled. We should move towards Target-define constrains instead of loose parameters.